Re: SQLExecDirectW returns SQL_SUCCESS even if sql finishes with error

From: "Jonah H(dot) Harris" <jonah(dot)harris(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: h-inoue(at)dream(dot)email(dot)ne(dot)jp, r(dot)takahashi_2(at)jp(dot)fujitsu(dot)com, pgsql-odbc(at)postgresql(dot)org
Subject: Re: SQLExecDirectW returns SQL_SUCCESS even if sql finishes with error
Date: 2018-11-02 16:08:47
Message-ID: CADUqk8V_N9pyjG3VNwWyMNpC0fqn3wML_kk1Lfa9-tB7j-Pg_Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-odbc

On Thu, Nov 1, 2018 at 10:50 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

> "Inoue, Hiroshi" <h-inoue(at)dream(dot)email(dot)ne(dot)jp> writes:
> > Could you please tell the customer that it's meaningless to set
> > client_min_messages to 'fatal' or 'panic'?
>
> Yeah, I wonder why we allow that at all. It's basically breaking
> the wire protocol ...
>

Agreed. I'll send in a patch if you want. It appears the fatal and panic
members of client_message_level_options in guc.c could be removed. The same
options are similarly used by trace_recovery_messages, but that seems to
make sense even in that regard. Likewise, postgresql.conf.sample only shows
debug5-error as options; omitting fatal and panic. The web docs, however,
show fatal and panic as options.

Thoughts?

--
Jonah H. Harris

In response to

Responses

Browse pgsql-odbc by date

  From Date Subject
Next Message Inoue, Hiroshi 2018-11-03 00:30:46 Re: NUMERIC type makes trouble in MS Access
Previous Message Tobias Wendorff 2018-11-02 14:01:19 Re: NUMERIC type makes trouble in MS Access