Re: Hi & some questions regarding Properties & contribution

Jurgen,

Implement properties as you see fit. With docs for them as well

There is no specific reason for not having the description property.

What is their contribution policy? Where do I find it?

Formatting the code en-masse will be a problem. If you want to format your
new files as per eclipse be my guest.

My basic rule is keep the formatting the same as whatever file you are
editing is. Formatting is a religious argument.

If I had my druthers formatting would be have lots of whitespace, and
others don't usually agree

ie function( int arg )
{
if ( something == something )
{
do something
}
}

as for header information it should have

Copyright (c) 2004-2014, PostgreSQL Global Development Group */

Feel free to fix headers in any other files you touch.

Thanks!!!

Dave Cramer

dave.cramer(at)credativ(dot)ca
http://www.credativ.ca

On 11 April 2014 18:00, Jürgen Rose <cptmauli(at)googlemail(dot)com> wrote:

> Hi,
>
> I'm Jürgen, new on this list and I'm currently osgifying the postgresql
> jdbc driver (https://github.com/pgjdbc/pgjdbc/issues/71)
>
> I have some questions regarding the conformity to the JDBC spec.
>
> In section 9.4.1 "DataSource Properties" it reads: The only property
> required for all DataSource implementations is description
>
> When I look at the implementation, there is no description property. Is
> there any specific reason for this?
>
> The spec also defines a number of other (optional) properties, most of
> them are not implemented. Wouldn't it be possible to implement at least
> some of them (dataSourceName, ...), just to be nice?
>
> I'm also talking with the IP people from the Eclipse foundation, so that
> the JDBC driver can be used as a dependency in some of the projects.
> This is not possible at the moment since it failed the validation (the
> Eclipse foundation is pretty strict). I'm still trying to find out what
> the specific problems are, but as far as I understand a contribution
> policy is missing (and maybe other things). And actually I didn't find
> one when I looked.
>
> Two things more, how to format the source code? It seems to me that the
> code is formatted relatively inconsistent. I'd love to have a formatter
> for Eclipse.
>
> What about the header information in the files? Some files have none,
> some have /* Copyright (c) 2004-2011, PostgreSQL Global Development
> Group */. What should I put into my new file?
>
>
> Jürgen
>
>
> --
> Sent via pgsql-jdbc mailing list (pgsql-jdbc(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-jdbc
>