From: | Dave Cramer <pg(at)fastcrypt(dot)com> |
---|---|
To: | Kevin Wooten <kdubb(at)me(dot)com> |
Cc: | pgsql-jdbc <pgsql-jdbc(at)postgresql(dot)org> |
Subject: | Re: DatabaseMetaData - schemaPattern |
Date: | 2013-11-25 13:53:05 |
Message-ID: | CADK3HHLg2k+dVxy8FPSCmqy0+7UszEm9ohEPhz5DSez+EGvaDg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-jdbc |
Kevin,
Thanks!
Dave Cramer
dave.cramer(at)credativ(dot)ca
http://www.credativ.ca
On Sat, Nov 23, 2013 at 3:47 PM, Kevin Wooten <kdubb(at)me(dot)com> wrote:
>
> In pgjdbc, I believe the DatabaseMetaData code is incorrectly handling
> the schemaPattern.
>
> According to the interface docs, an empty schemaPattern should retrieve
> “those without a schema”. While null means "the schemaPattern should not be
> used to narrow the search”. This same info appears for any schemaPattern
> in any method of the interface (
> http://docs.oracle.com/javase/7/docs/api/java/sql/DatabaseMetaData.html)
>
> All through AbstractJdbc2DatabaseMetaData.java, anywhere schemaPattern
> appears, you’ll see code like this:
>
> if (schemaPattern != null && !"".equals(schemaPattern))
> {
> sql += ...
> }
>
> It seems these should simply be null checks only. Does that seem like the
> correct interpretation?
>
> -kw
>
> --
> Sent via pgsql-jdbc mailing list (pgsql-jdbc(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-jdbc
>
From | Date | Subject | |
---|---|---|---|
Next Message | Marc Mamin | 2013-11-27 09:04:15 | JDBC & custom type of variable types (!) |
Previous Message | Kevin Wooten | 2013-11-23 20:47:23 | DatabaseMetaData - schemaPattern |