| From: | Dave Cramer <pg(at)fastcrypt(dot)com> |
|---|---|
| To: | Pavel Kajaba <pkajaba(at)redhat(dot)com> |
| Cc: | Vladimir Sitnikov <sitnikov(dot)vladimir(at)gmail(dot)com>, Stephen Nelson <stephen(at)eccostudio(dot)com>, List <pgsql-jdbc(at)postgresql(dot)org>, Pavel Raiskup <praiskup(at)redhat(dot)com> |
| Subject: | Re: [pgjdbc] Implement JDBC specs via pre-processor step (#435) |
| Date: | 2016-01-19 14:32:49 |
| Message-ID: | CADK3HHLdSTnR9CKNot+1=-B3j+mWeSf98FVMWGyNb=suoh_P1Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-jdbc |
On 19 January 2016 at 09:31, Pavel Kajaba <pkajaba(at)redhat(dot)com> wrote:
> > Well to start with there are other operating systems besides Linux. I'd
> > suggest reversing the logic to test for Windows.
>
> Ok, it's trivial change.
>
> > Is there some reason not to use github ?
>
> Just a habbit and I wanted you to show it before committing to github.
>
The advantage of github pull requests is that travis will build it for you
and make sure it compiles etc. Nothing gets committed.
Dave Cramer
davec(at)postgresintl(dot)com
www.postgresintl.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thom Brown | 2016-01-19 14:34:54 | Re: Patch: Implement failover on libpq connect level. |
| Previous Message | Pavel Kajaba | 2016-01-19 14:31:25 | Re: [pgjdbc] Implement JDBC specs via pre-processor step (#435) |