Re: [BUGS]log can not be output when use DataSource

From: Dave Cramer <pg(at)fastcrypt(dot)com>
To: Chen Huajun <chenhj(at)cn(dot)fujitsu(dot)com>
Cc: dmp <danap(at)ttc-cmc(dot)net>, List <pgsql-jdbc(at)postgresql(dot)org>
Subject: Re: [BUGS]log can not be output when use DataSource
Date: 2013-01-28 12:06:16
Message-ID: CADK3HHLYUL52uSg37E_0a8R-W-n1V7r0KpwGQ2Hnw__OtQRqCQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-jdbc

Chen,

This is excellent work.

I don't see any reason why all of the documented url parameters should not
be available manually, and in both the data source and the connection.

Dave

Dave Cramer

dave.cramer(at)credativ(dot)ca
http://www.credativ.ca

On Mon, Jan 28, 2013 at 6:28 AM, Chen Huajun <chenhj(at)cn(dot)fujitsu(dot)com> wrote:

> Hi
>
> I reviewed the source related to properties.
> My idea is that the set of supported properties should be the same
> no matter the means of setting value(by url or by DataSource).
> So I get all properties by searching keyword ".getProperty(" in pgjdbc
> source,
> and then check whether BaseDataSource has correctly deal with all them.
> As a result i found many inconsistencies as listed in the attachment.
>
> I am wondering about if it's needed to add all lacked properties to
> BaseDataSource?
>
>
> Chen Huajun
>
> (2013/01/24 2:35), dmp wrote:
>
>> Thank you sir for helping in identifying problems with the pgjdbc
>> code and contributing to maintaining this project.
>>
>> danap.
>>
>> Chen Huajun wrote:
>>
>>> danap,
>>>
>>> > Could you and possibly while considering the new possible bug you
>>> found with
>>> > copying DataSource do a more through review of the BaseDataSource
>>> class?
>>>
>>> OK,I will review the BaseDataSource class first.
>>>
>>>
>>
>>
>>
>
>
> --
> Sent via pgsql-jdbc mailing list (pgsql-jdbc(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-jdbc
>
>

In response to

Responses

Browse pgsql-jdbc by date

  From Date Subject
Next Message Hari Babu 2013-01-28 14:03:00 JDBC connection test with SSL on PG 9.2.1 server
Previous Message Chen Huajun 2013-01-28 11:28:05 Re: [BUGS]log can not be output when use DataSource