From: | Dave Cramer <pg(at)fastcrypt(dot)com> |
---|---|
To: | Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp> |
Cc: | Vladimir Sitnikov <sitnikov(dot)vladimir(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: extended query protcol violation? |
Date: | 2018-12-08 10:53:46 |
Message-ID: | CADK3HHL5zaGOHXSPW5tokcbajpR1G7atyC+FfbFLBem_85Fzgw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sat, 8 Dec 2018 at 05:16, Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp> wrote:
> > Tatsuo>responses of a simple query do not include CloseComplete
> >
> > Tatsuo, where do you get the logs from?
>
> As I said, pgproto.
>
> https://github.com/tatsuo-ishii/pgproto
>
> > I guess you are just confused by the PRINTED order of the messages in the
> > log.
> > Note: wire order do not have to be exactly the same as the order in the
> log
> > since messages are buffered, then might be read in batches.
>
> pgproto directly reads from socket using read system call. There's no
> buffer here.
>
> > In other words, an application might just batch (send all three)
> close(s2),
> > close(s1), query(begin) messages, then read the responses.
> > How does it break protocol?
>
> Again as I said before, the doc says in extended query protocol a
> sequence of extended messages (parse, bind. describe, execute, closes)
> should be followed by a sync message. ie.
>
> close
> close
> sync
> query(begin)
>
> Maybe
>
> close
> close
> query(begin)
>
> is not a violation of protocol, but still I would say this is buggy
> because of the reason Tom said, and I agree with him.
>
Curious what client is this that is violating the protocol.
Dave Cramer
davec(at)postgresintl(dot)com
www.postgresintl.com
>
>
From | Date | Subject | |
---|---|---|---|
Next Message | Vladimir Sitnikov | 2018-12-08 10:56:49 | Re: extended query protcol violation? |
Previous Message | Amit Kapila | 2018-12-08 10:52:31 | Re: Undo logs |