Re: Fix for REFRESH MATERIALIZED VIEW ownership error message

From: Dave Cramer <pg(at)fastcrypt(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fix for REFRESH MATERIALIZED VIEW ownership error message
Date: 2018-08-17 23:39:04
Message-ID: CADK3HHKY=4Z-B6j0LtG9N2a7OCzrJ=ic6OZxYQASwkvcm7CDfQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, 17 Aug 2018 at 19:35, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
wrote:

> On 2018-Aug-17, Dave Cramer wrote:
>
> > The only place this is used is in aclcheck_error
> > case OBJECT_MATVIEW:
> > msg = gettext_noop("permission denied for materialized view %s");
> > break;
>
> Yes, but do we pass RefreshMatViewStmt->relkind to that routine? I
> don't see that we do. Maybe I misread the code.
>

Actually the code path that gets executed is:

case OBJECT_MATVIEW:
msg = gettext_noop("must be owner of materialized view %s");
break;

as I have the patch applied and now see:

\c - test
You are now connected to database "test" as user "test".
test=> refresh materialized view b;
ERROR: must be owner of materialized view b

Dave Cramer

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2018-08-18 01:02:09 Re: Getting NOT NULL constraint from pg_attribute
Previous Message Alvaro Herrera 2018-08-17 23:35:12 Re: Fix for REFRESH MATERIALIZED VIEW ownership error message