| From: | Dave Cramer <davecramer(at)postgres(dot)rocks> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Michael Paquier <michael(at)paquier(dot)xyz>, Anthony Roberts <anthony(dot)roberts(at)linaro(dot)org>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Lina Iyer <lina(dot)iyer(at)linaro(dot)org>, Mike Holmes <mike(dot)holmes(at)linaro(dot)org>, Peter Eisentraut <peter(at)eisentraut(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: [PATCH] Add native windows on arm64 support |
| Date: | 2024-02-13 21:28:49 |
| Message-ID: | CADK3HHJzjaFoGkHExy7GxwcraM3AiyUsqAw5GP9z_g0Tkpf64g@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 13 Feb 2024 at 12:52, Andres Freund <andres(at)anarazel(dot)de> wrote:
> Hi,
>
> On 2024-02-13 12:49:33 -0500, Dave Cramer wrote:
> > > I think I might have been on to something - if my human emulation of a
> > > preprocessor isn't wrong, we'd end up with
> > >
> > > #define S_UNLOCK(lock) \
> > > do { _ReadWriteBarrier(); (*(lock)) = 0; } while (0)
> > >
> > > on msvc + arm. And that's entirely insufficient - _ReadWriteBarrier()
> just
> > > limits *compiler* level reordering, not CPU level reordering. I think
> it's
> > > even insufficient on x86[-64], but it's definitely insufficient on arm.
> > >
> > In fact ReadWriteBarrier has been deprecated _ReadWriteBarrier |
> Microsoft
> > Learn
> > <
> https://learn.microsoft.com/en-us/cpp/intrinsics/readwritebarrier?view=msvc-170
> >
>
> I'd just ignore that, that's just pushing towards more modern stuff that's
> more applicable to C++ than C.
>
>
> > I did try using atomic_thread_fence as per atomic_thread_fence -
> > cppreference.com
> > <https://en.cppreference.com/w/c/atomic/atomic_thread_fence>
>
> The semantics of atomic_thread_fence are, uh, very odd. I'd just use
> MemoryBarrier().
>
> #define S_UNLOCK(lock) \
do { MemoryBarrier(); (*(lock)) = 0; } while (0)
#endif
Has no effect.
I have no idea if that is what you meant that I should do ?
Dave
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2024-02-13 21:29:28 | Re: [PATCH] allow pg_current_logfile() execution under pg_monitor role |
| Previous Message | Thomas Munro | 2024-02-13 21:17:37 | Re: DSA_ALLOC_NO_OOM doesn't work |