| From: | Dave Cramer <davecramer(at)gmail(dot)com> |
|---|---|
| To: | Violet Cheng <vcheng(at)pivotal(dot)io> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>, Sarah McAlear <smcalear(at)pivotal(dot)io> |
| Subject: | Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display |
| Date: | 2017-08-18 12:37:09 |
| Message-ID: | CADK3HHJLedC=bOnQwkSnU3D9GNS4Suqd-1zevd-PuNCqm=bSmw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi Violet.
I don't really like the way this has been implemented. It adds a variable
which is only used for gpdb.
There are other places in the code where the behaviour is changed if the
server is ppas or regular postgres.
Candidly I think all of this needs restructuring.
Dave Cramer
On 15 August 2017 at 23:29, Violet Cheng <vcheng(at)pivotal(dot)io> wrote:
> Hi,
>
> Any comment on this patch? If no, will it be committed soon?
>
> Thanks,
> Violet
>
> On Wed, Aug 9, 2017 at 12:05 PM, Sarah McAlear <smcalear(at)pivotal(dot)io>
> wrote:
>
>> Hi Hackers!
>>
>> This patch enables Greenplum users to see the same charts on the
>> dashboard as postgres users. It also adds some additional information to
>> the DDL that is Greenplum specific and necessary to create a new table.
>>
>> Thanks!
>> Sarah
>>
>>
>>
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Krennwallner | 2017-08-20 17:17:52 | PATCH: pgagent connection string parsing |
| Previous Message | Dave Page | 2017-08-18 08:05:22 | Re: pgAdmin4: Random failure of FTS test cases due to improper random string creation |