| From: | Rachel Heaton <rachelmheaton(at)gmail(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Michael Paquier <michael(at)paquier(dot)xyz>, Jacob Champion <pchampion(at)vmware(dot)com>, "hlinnaka(at)iki(dot)fi" <hlinnaka(at)iki(dot)fi>, "andrew(dot)dunstan(at)2ndquadrant(dot)com" <andrew(dot)dunstan(at)2ndquadrant(dot)com>, "andres(at)anarazel(dot)de" <andres(at)anarazel(dot)de>, "thomas(dot)munro(at)gmail(dot)com" <thomas(dot)munro(at)gmail(dot)com>, "sfrost(at)snowman(dot)net" <sfrost(at)snowman(dot)net> |
| Subject: | Re: Support for NSS as a libpq TLS backend |
| Date: | 2021-09-27 23:07:19 |
| Message-ID: | CADJcwiVzWTs_xtt421ghkxAtoJ1p472psOHe6kAjHdN=X9kY+g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Sep 20, 2021 at 2:38 AM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
> Rebased on top of HEAD with off-list comment fixes by Kevin Burke.
>
Hello Daniel,
I've been playing with your patch on Mac (OS 11.6 Big Sur) and have
run into a couple of issues so far.
1. I get 7 warnings while running make (truncated):
cryptohash_nss.c:101:21: warning: implicit conversion from enumeration
type 'SECOidTag' to different enumeration type 'HASH_HashType'
[-Wenum-conversion]
ctx->hash_type = SEC_OID_SHA1;
~ ^~~~~~~~~~~~
...
cryptohash_nss.c:134:34: warning: implicit conversion from enumeration
type 'HASH_HashType' to different enumeration type 'SECOidTag'
[-Wenum-conversion]
hash = SECOID_FindOIDByTag(ctx->hash_type);
~~~~~~~~~~~~~~~~~~~ ~~~~~^~~~~~~~~
7 warnings generated.
2. libpq-refs-stamp fails -- it appears an exit is being injected into
libpq on Mac
Notes about my environment:
I've installed nss via homebrew (at version 3.70) and linked it.
Cheers,
Rachel
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2021-09-27 23:43:13 | Re: Fixing WAL instability in various TAP tests |
| Previous Message | Rachel Heaton | 2021-09-27 22:55:02 | [PATCH] Print error when libpq-refs-stamp fails |