| From: | Douglas Doole <dougdoole(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Konstantin Knizhnik <k(dot)knizhnik(at)postgrespro(dot)ru>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Push limit to sort through a subquery |
| Date: | 2017-08-18 20:08:28 |
| Message-ID: | CADE5jY+BOPdtzR1H0GtNqE2hf3D-eCEiS6_-esmVt4XtZf-kDg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>
> 1. The header comment for pass_down_bound() could mention "one or more
> levels of subqueries" rather than "a subquery".
>
Fixed
2. The first of the comments in the function body appears to have a
> whitespace issue that needs to be fixed manually or, better yet,
> addressed by pgindent.
>
Fixed
> 3. The formatting of the comment in the regression tests appears to be
> unlike any other comment in that same file.
>
A side effect of inheriting it from our branches ;-) Reworked.
> 4. I am pretty doubtful that "Memory: 25kB" is going to be stable
> enough for us to want that output memorialized in the regression ...
>
Fair enough. I wanted to be a bit more sophisticated in my check than
looking for a single value so I worked out something that distills the
explain down to the key elements.
| Attachment | Content-Type | Size |
|---|---|---|
| limitSQsort.v3.patch | text/x-patch | 4.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2017-08-18 21:43:19 | Re: possible encoding issues with libxml2 functions |
| Previous Message | Robert Haas | 2017-08-18 19:51:52 | Re: expanding inheritance in partition bound order |