Re: [PATCH] Add PQconninfoParseParams and PQconninfodefaultsMerge to libpq

On Mon, Feb 4, 2013 at 9:13 AM, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
>
>> > On Feb 3, 2013 4:16 AM, "Phil Sorber" <phil(at)omniti(dot)com> wrote:
>> >>
>> >> This patch came up from discussion about pg_isready.
>> >>
>> >> PQconninfoParseParams is similar to PQconninfoParse but takes two
>> >> arrays like PQconnectdbParams. It essentially exposes
>> >> conninfo_array_parse().
>> >>
>> >> PQconninfodefaultsMerge essentially exposes conninfo_add_defaults().
>> >> It allows you to pass a PQconninfoOption struct and it adds defaults
>> >> for all NULL values.
>
> Uh, no existing code can use this new functionality? That seems
> disappointing.
>

I wrote this because I wanted to use it in pg_isready. I also wrote
something for pg_isready to get around not having this. I think adding
these two functions to libpq would be the better option, but wanted
something that could fix an existing issue without having to patch
libpq so late in the 9.3 development process. Actually, I think it was
you who suggested that approach.

So long answer short, there is existing code that can use this
functionality immediately.

>
> --
> Álvaro Herrera http://www.2ndQuadrant.com/
> PostgreSQL Development, 24x7 Support, Training & Services