Re: getopt() and strdup()

From: Phil Sorber <phil(at)omniti(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: getopt() and strdup()
Date: 2012-10-13 19:28:01
Message-ID: CADAkt-hTNFX9TekjiX7cbK-OLKd7dxJ34fUTZhHz4dfyBbCAqw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Oct 13, 2012 at 3:14 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Phil Sorber <phil(at)omniti(dot)com> writes:
>> On Wed, Oct 10, 2012 at 7:54 PM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
>>> Also, do we want to centralize the definition of pg_strdup() in /port,
>>> or leave each module to define it on its own?
>
>> +1 for a centralized definition.
>
> The difficulty with a centralized definition is that it's not clear that
> the error path is or should be *exactly* the same for all these usages.
> I see at least six variants right now. While some are gratuitous,
> some of them are tied into local conventions of each program.
>
> regards, tom lane

Is it possible to at least standardize on one for the front-end and
one for the back-end? Then we can use those two going forward and sort
out all these other usages and get them to conform to one of the
aforementioned definitions over time.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2012-10-13 19:45:47 Re: Optimizer regression
Previous Message Magnus Hagander 2012-10-13 19:14:55 Re: Adding comments for system table/column names