Re: pgsql: make dist uses git archive

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: make dist uses git archive
Date: 2024-03-26 08:13:32
Message-ID: CAD5tBcLm3OoT0F=ZjR5HzsEgy6m=sNUzURQYxwxnASp8w0iVcA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Tue, Mar 26, 2024 at 3:20 AM Peter Eisentraut <peter(at)eisentraut(dot)org>
wrote:

> On 25.03.24 23:20, Andrew Dunstan wrote:
> > The problem occurs because except in vpath mode the buildfarm operates
> > on a copy of the code, and for efficiency reasons we don't copy the ,git
> > directory.
> >
> > The simplest fix is probably to change the machine's config to use a
> > vpath build.
> >
> > In the config file change the undef here to a 1:
> >
> > 'use_vpath' => undef,
> >
> > That worked for me in a quick test.
>
> Note that "make dist" doesn't work with vpath in backbranches. :-/
>

Ugh.

OK, plan B :

In the Module's setup code, right after the "die", put

symlink("$buildroot/$branch/pgsql/.git","$pgsql/.git");

cheers

andrew

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Amit Kapila 2024-03-26 08:15:23 Re: pgsql: Track last_inactive_time in pg_replication_slots.
Previous Message Alvaro Herrera 2024-03-26 07:39:52 Re: pgsql: Track last_inactive_time in pg_replication_slots.