From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
---|---|
To: | Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: WIP Incremental JSON Parser |
Date: | 2024-03-21 06:56:00 |
Message-ID: | CAD5tBcLm=+LUrGZftmRGxq1tWE9eAcviVJgEF=AX8P_=NDd=eg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Mar 20, 2024 at 3:06 PM Jacob Champion <
jacob(dot)champion(at)enterprisedb(dot)com> wrote:
> This new return path...
>
> > + if (!tok_done)
> > + {
> > + if (lex->inc_state->is_last_chunk)
> > + return JSON_INVALID_TOKEN;
>
> ...also needs to set the token pointers. See one approach in the
> attached diff, which additionally asserts that we've consumed the
> entire chunk in this case, along with a handful of new tests.
>
Thanks, included that and attended to the other issues we discussed. I
think this is pretty close now.
cheers
andrew
Attachment | Content-Type | Size |
---|---|---|
v13-0001-Introduce-a-non-recursive-JSON-parser.patch | text/x-patch | 429.4 KB |
v13-0002-Add-support-for-incrementally-parsing-backup-man.patch | text/x-patch | 7.6 KB |
v13-0003-Use-incremental-parsing-of-backup-manifests.patch | text/x-patch | 11.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Masahiko Sawada | 2024-03-21 07:02:05 | Re: [PoC] Improve dead tuple storage for lazy vacuum |
Previous Message | Bertrand Drouvot | 2024-03-21 06:50:12 | Re: Introduce XID age and inactive timeout based replication slot invalidation |