| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Missing generated column in ALTER TABLE ADD COLUMN doc |
| Date: | 2019-06-11 04:49:02 |
| Message-ID: | CAD21AoDujoL9QK2dgODWB80g1PvgPRWqystzCxQFgXektdv-cA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jun 11, 2019 at 1:02 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Mon, Jun 10, 2019 at 06:09:53PM +0900, Masahiko Sawada wrote:
> > We already have the following line in action part but you mean we need
> > an extra line for that?
> >
> > ADD [ COLUMN ] [ IF NOT EXISTS ] column_name data_type [ COLLATE
> > collation ] [ column_constraint [ ... ] ]
>
> I was looking at the grammar extensions for ADD GENERATED and noticed
> what looked like inconsistencies, but your patch as well as the parsed
> query are right. Committed, thanks!
Thank you!
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2019-06-11 04:56:31 | pgbench rate limiting changes transaction latency computation |
| Previous Message | Fabien COELHO | 2019-06-11 04:46:41 | Re: fix psql \conninfo & \connect when using hostaddr |