From: | Sawada Masahiko <sawada(dot)mshk(at)gmail(dot)com> |
---|---|
To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, David Johnston <david(dot)g(dot)johnston(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Merging postgresql.conf and postgresql.auto.conf |
Date: | 2015-01-21 16:13:51 |
Message-ID: | CAD21AoDugFQCxvYO03ALA5XR=iuG0uYhyYPBvB27Ut72T67emQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Jan 21, 2015 at 3:38 PM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> On Tue, Jan 20, 2015 at 9:38 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>
> Okay and I was also not in favour of this approach.
>
Okay I agree with this.
>
> The reason why "sourcefile" and "sourceline" are not sufficient is that
> they can only give the information about the setting in last file it is
> present. Assume max_connections (or any other setting) is available
> in both postgresql.conf and postgresql.auto.conf, then it will display
> the information about the setting in postgresql.auto.conf, so now user
> might not be able to decide whether that is the setting he want to retain
> unless he knows the information about setting in postgresql.conf.
>
> Now as I have suggested upthread, that we can have a new view
> pg_file_settings which will display information about settings even
> when there exists multiple entries for the same in different files.
>
> I think adding such information to existing view pg_settings would
> be difficult as the same code is used for show commands which
> we don't want to change.
>
I think this new view is updated only when postmaster received SIGHUP
or is started.
And we can have new function like pg_update_file_setting() which
updates this view.
Regards,
-------
Sawada Masahiko
From | Date | Subject | |
---|---|---|---|
Next Message | Arne Scheffer | 2015-01-21 16:21:01 | Re: Add min and max execute statement time in pg_stat_statement |
Previous Message | Alvaro Herrera | 2015-01-21 15:21:27 | Re: TODO : Allow parallel cores to be used by vacuumdb [ WIP ] |