| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Replication slot drop message is sent after pgstats shutdown. |
| Date: | 2021-08-31 08:14:45 |
| Message-ID: | CAD21AoDsx3Lg+0B2jt7oa-5_hmQ+xgA9V1s-8hXG++b8nEFt-w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Aug 31, 2021 at 2:34 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
>
> On 2021-08-31 14:22:39 +0900, Masahiko Sawada wrote:
> > You mean to move only the part of sending the message to its own
> > before_shmem_exit() callback? or move ReplicationSlotRelease() and
> > ReplicationSlotCleanup() from ProcKill() to it?
>
> The latter.
Makes sense.
I've attached the patch that moves them to its own
before_shmem_exit(). Unless I missed to register the callback it works
the same as before except for where to release and clean up the slots.
Regards,
--
Masahiko Sawada
EDB: https://www.enterprisedb.com/
| Attachment | Content-Type | Size |
|---|---|---|
| move_slot_release_to_before_shmem_exit.patch | application/octet-stream | 4.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Denis Hirn | 2021-08-31 08:16:47 | Re: [PATCH] Allow multiple recursive self-references |
| Previous Message | Fabien COELHO | 2021-08-31 07:56:39 | Re: Fix around conn_duration in pgbench |