Re: Improvement in log message of logical replication worker

From: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Improvement in log message of logical replication worker
Date: 2017-05-17 09:15:04
Message-ID: CAD21AoDsUNzdqQ+qoyAXA9+PCgDsm+U5+SvNXkictVL+u8UiBw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, May 17, 2017 at 11:33 AM, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> On Wed, May 17, 2017 at 4:08 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> On Fri, May 12, 2017 at 12:30 AM, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>>> Attached small patch adds relid to these log messages if it's valid.
>>> I'd like to propose it for PG10 if possible, but since It's not a bug
>>> and not an open item we can add it to next CF.
>>
>> To me, it seems completely reasonable to add this as an open item.
>>
>
> Okay, added this to the open items.
>

Attached minor updated patch.

BTW, why should max_replication_slots be set more than 0 even on the
subscriber side? It's documented but I could not understand reason..

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

Attachment Content-Type Size
log_message_improvement_for_logical_repl_v2.patch application/octet-stream 1.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2017-05-17 09:17:43 Re: Adding support for Default partition in partitioning
Previous Message Etsuro Fujita 2017-05-17 09:06:29 Re: Bug in ExecModifyTable function and trigger issues for foreign tables