Re: pgsql: Logical replication support for initial data copy

On Fri, Mar 24, 2017 at 12:59 AM, Peter Eisentraut
<peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
> On 3/23/17 10:25, Petr Jelinek wrote:
>> On 23/03/17 15:17, Stephen Frost wrote:
>>> Petr,
>>>
>>> * Petr Jelinek (petr(dot)jelinek(at)2ndquadrant(dot)com) wrote:
>>>> On 23/03/17 14:47, Petr Jelinek wrote:
>>>>> I am looking into buildfarm failures.
>>>>>
>>>>> Looks like the clang issue (mylodon, longfin) is because we are missing
>>>>> extern in include/replication/worker_internal.h for ApplyCacheContext.
>>>>>
>>>>> Still analyzing the rest.
>>>>
>>>> Ah missing fields in copy/equal function for AlterSubscriptionStmt.
>>>>
>>>> Attached patch adds the above mentioned extern and fixes the copy and
>>>> equal functions.
>>>
>>> Pretty sure I saw a complaint about a trailing comma in a struct or enum
>>> too..
>>>
>>
>> Ah, missed that in the wall of text, thanks, fixed that too.
>
> Also fixed.
>

The copyright in some files(tablesync.c and pg_subscriptiion_rel.h)
introduced by this commit are old. Is that intentional? Attached
patch.

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center