From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
---|---|
To: | John Naylor <johncnaylorls(at)gmail(dot)com> |
Cc: | David Rowley <dgrowleyml(at)gmail(dot)com>, Masahiko Sawada <msawada(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | Re: pgsql: Add TIDStore, to store sets of TIDs (ItemPointerData) efficientl |
Date: | 2024-03-26 03:48:57 |
Message-ID: | CAD21AoDnFaWEpSuNaTKjqmmzqMqmQuC8w2kqmw4z1R0O4eX-TQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
On Tue, Mar 26, 2024 at 12:22 PM John Naylor <johncnaylorls(at)gmail(dot)com> wrote:
>
> On Tue, Mar 26, 2024 at 9:36 AM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> >
> > On Tue, Mar 26, 2024 at 7:16 AM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> > >
> > > Either "max_bytes" is a bad name for this variable or the * 1024L
> > > should be removed.
> > >
> >
> > Right. We discussed it on the original thread too[1]. Since we're
> > going to change the create API of TidStore, I'm going to fix it along
> > with the API changes[2]. Even if we don't make the API change, I'll
> > fix it individually.
>
> v79 still has the offending multiplier, btw. Those two things are
> unrelated anyway, so I don't see a reason to hold off making this
> small fix.
Okay, I'll fix them shortly.
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
From | Date | Subject | |
---|---|---|---|
Next Message | Masahiko Sawada | 2024-03-26 04:07:05 | pgsql: Fix a calculation in TidStoreCreate(). |
Previous Message | Andres Freund | 2024-03-26 03:28:23 | pgsql: Avoid edge case in pg_visibility test with small shared_buffers |