From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
---|---|
To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
Cc: | Shubham Khanna <khannashubham1197(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Rajendra Kumar Dangwal <dangwalrajendra888(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, euler(at)eulerto(dot)com |
Subject: | Re: Pgoutput not capturing the generated columns |
Date: | 2024-09-27 00:03:14 |
Message-ID: | CAD21AoDmAkRRG6=0rp_0f6keg0p+mZb75VyfjQ_OW2Bohz5Z8w@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Sep 25, 2024 at 11:15 PM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> Hi, I have written a new patch to document this feature.
>
> The patch adds a new section to the "Logical Replication" chapter. It
> applies atop the existing patches.
>
> v33-0001 (same as v32-0001)
> v33-0002 (same as v32-0002)
> v33-0003 (new DOCS)
>
> Review comments are welcome.
Thank you for updating the patch!
I think that the patch doesn't have regression tests to check if
generated column data is replicated to the subscriber as expected. I
think we should include some tests for this feature (especially with
other features such as column list).
Also, when testing this feature, I got the following warning message
even if the publication has publish_generated_columns = true:
=# create publication pub for table test (a, c) with
(publish_generated_columns = true);
WARNING: specified generated column "c" in publication column list
for publication with publish_generated_columns as false
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
From | Date | Subject | |
---|---|---|---|
Next Message | Euler Taveira | 2024-09-27 00:30:05 | Re: Truncate logs by max_log_size |
Previous Message | Michael Paquier | 2024-09-26 23:17:53 | Re: query_id, pg_stat_activity, extended query protocol |