| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Hamid Akhtar <hamid(dot)akhtar(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Subject: | Re: {CREATE INDEX, REINDEX} CONCURRENTLY improvements |
| Date: | 2021-01-04 10:55:40 |
| Message-ID: | CAD21AoDcUZfh=D05gwmG9_=uqAjH7AiVwqP8geMn=nZ=DpVupA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Dec 8, 2020 at 5:18 PM Hamid Akhtar <hamid(dot)akhtar(at)gmail(dot)com> wrote:
>
> The following review has been posted through the commitfest application:
> make installcheck-world: tested, passed
> Implements feature: not tested
> Spec compliant: not tested
> Documentation: not tested
>
> The patch looks good to me. With regards to the code comments, I had pretty similar concerns as already raised by Dmitry; and those have already been answered by you. So this patch is good to go from my side once you have updated the comments per your last email.
For the 0001 patch, since ReindexIndexInfo is used only within
ReindexRelationConcurrently() I think it’s a function-local structure
type. So we can declare it within the function. What do you think?
Regards,
--
Masahiko Sawada
EnterpriseDB: https://www.enterprisedb.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2021-01-04 11:14:24 | Re: poc - possibility to write window function in PL languages |
| Previous Message | Luc Vlaming | 2021-01-04 10:52:29 | Re: Parallel Inserts in CREATE TABLE AS |