| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Huong Dangminh <huo-dangminh(at)ys(dot)jp(dot)nec(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Magnus Hagander <magnus(at)hagander(dot)net>, Bruce Momjian <bruce(at)momjian(dot)us>, "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Hiroshi Yanagisawa <hir-yanagisawa(at)ut(dot)jp(dot)nec(dot)com> |
| Subject: | Re: [PostgreSQL 10] default of hot_standby should be "on"? |
| Date: | 2017-04-28 01:43:04 |
| Message-ID: | CAD21AoDTityRpbzqLKm1Emr6y4bvsDs6SFiLkTse9468245JgA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Apr 27, 2017 at 11:05 PM, Huong Dangminh
<huo-dangminh(at)ys(dot)jp(dot)nec(dot)com> wrote:
>> >>> I would refrain from doing that, having some parameters listed in the
>> >>> tests makes the intention behind those perl routines clear.
>> >
>> > Hmm, you've got a point. But when we changed the default values
>> > related to replication we dropped some explicitly settings from the
>> > regression test code.
>>
>> Looking at the patch. This is fine:
>> - # Change a setting and restart
>> - $node->append_conf('postgresql.conf', 'hot_standby = on');
>> - $node->restart();
>>
>> But not that:
>> print $conf "wal_log_hints = on\n";
>> - print $conf "hot_standby = on\n";
>> print $conf "max_connections = 10\n";
>>
>> This is a minor point though.
After some thoughts I agree to remain it in the perl code.
>
> Thanks, I attached the update patch.
So it looks good to me.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2017-04-28 02:49:05 | Re: PG 10 release notes |
| Previous Message | Masahiko Sawada | 2017-04-28 01:36:46 | Re: subscription worker doesn't start immediately on eabled |