Re: pgsql: pg_logicalinspect: Fix possible crash when passing a directory p

From: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: Masahiko Sawada <msawada(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: pg_logicalinspect: Fix possible crash when passing a directory p
Date: 2025-03-12 04:56:14
Message-ID: CAD21AoDQJdQG3V3zvH7x9rEF97E8VD5OarArfpY+f4bEK5wNkw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Tue, Mar 11, 2025 at 7:08 PM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
>
> On Wed, 12 Mar 2025 at 05:57, Masahiko Sawada <msawada(at)postgresql(dot)org> wrote:
> > contrib/pg_logicalinspect/pg_logicalinspect.c | 55 ++++++++++++---
>
> This introduces a new compiler warning for compilers that don't know
> the ereport(ERROR) does not return.
>
> The attached is enough to fix it.

Thank you for the report. Can we generate the warning using some gcc's
warning flags? I'd like to add a check to my personal pre-commit test.

Regards,

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2025-03-12 05:18:09 Re: pgsql: pg_logicalinspect: Fix possible crash when passing a directory p
Previous Message Tom Lane 2025-03-12 04:08:01 Re: pgsql: Doc: silence A4 PDF build warnings.