Re: pgsql: pg_upgrade: Preserve default char signedness value from old clus

From: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Masahiko Sawada <msawada(at)postgresql(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: pg_upgrade: Preserve default char signedness value from old clus
Date: 2025-03-18 04:35:43
Message-ID: CAD21AoDKj2PWJN9AW+0ENfu4q0kvE0D+R-wEY0mSdWv+q4=bBg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Mon, Mar 17, 2025 at 8:02 PM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>
> On Mon, Mar 17, 2025 at 6:02 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> > I've confirmed the issue and attached a patch to fix it.
>
> Cool. The commit message refers to 003_char_signedness, but the test
> name is 005, not 003.

Thank you for reviewing the patch. I've pushed the patch after fixing it.

Regards,

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Amit Kapila 2025-03-18 06:30:04 Re: pgsql: Avoid invalidating all RelationSyncCache entries on publication
Previous Message Masahiko Sawada 2025-03-18 04:34:27 pgsql: Fix the test 005_char_signedness.

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2025-03-18 05:34:52 Re: pg_recvlogical requires -d but not described on the documentation
Previous Message Daniil Davydov 2025-03-18 04:26:49 Re: Forbid to DROP temp tables of other sessions