| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Make pg_waldump report replication origin ID, LSN, and timestamp. |
| Date: | 2021-12-09 08:42:56 |
| Message-ID: | CAD21AoDJhE0n-j3Ns201j4QjCvrR+t0xJrNpr_gzT_JL3xv66g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Dec 9, 2021 at 4:02 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Wed, Dec 08, 2021 at 05:03:30PM +0900, Masahiko Sawada wrote:
> > Agreed. I've attached an updated patch that incorporated your review
> > comments. Please review it.
>
> That looks correct to me. One thing that I have noticed while
> reviewing is that we don't check XactCompletionApplyFeedback() in
> xact_desc_commit(), which would happen if a transaction needs to do
> a remote_apply on a standby. synchronous_commit is a user-settable
> parameter, so it seems to me that it could be useful for debugging?
>
Agreed.
Thank you for updating the patch. The patch looks good to me.
Regards,
--
Masahiko Sawada
EDB: https://www.enterprisedb.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2021-12-09 08:53:49 | Re: Skipping logical replication transactions on subscriber side |
| Previous Message | Michael Paquier | 2021-12-09 08:17:54 | Re: GUC flags |