Re: Small documentation improvement for ALTER SUBSCRIPTION

From: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Small documentation improvement for ALTER SUBSCRIPTION
Date: 2021-09-08 11:41:13
Message-ID: CAD21AoDBCvPoME3J6URBsB1XazV1de0ni2fdARWV4xg7_8Rk2Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Sep 7, 2021 at 9:01 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
> > On 7 Sep 2021, at 13:36, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> wrote:
> >
> > On 12.08.21 04:52, Masahiko Sawada wrote:
> >> On Wed, Aug 11, 2021 at 5:42 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
> >>>
> >>>> On 11 Aug 2021, at 09:57, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> >>>
> >>>> Additionally, refresh options as described in
> >>>> <replaceable>refresh_option</replaceable> of
> >>>> <literal>REFRESH PUBLICATION</literal> may be specified,
> >>>> except in the case of <literal>DROP PUBLICATION</literal>.
> >>>
> >>> Since this paragraph is under the literal option “refresh”, which takes a
> >>> value, I still find your original patch to be the clearest.
> >> Yeah, I prefer my original patch over this idea. On the other hand, I
> >> can see the point of review comment on it that Amit pointed out[1].
> >
> > How about this:
> >
> > - Additionally, refresh options as described
> > - under <literal>REFRESH PUBLICATION</literal> may be specified.
> > + Additionally, the options described under <literal>REFRESH
> > + PUBLICATION</literal> may be specified, to control the implicit refresh
> > + operation.
>
> LGTM.

+1

Attached the patch.

Regards,

--
Masahiko Sawada
EDB: https://www.enterprisedb.com/

Attachment Content-Type Size
alter_subscription_doc_v2.patch application/octet-stream 711 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message vignesh C 2021-09-08 11:44:18 Re: Added schema level support for publication.
Previous Message Dilip Kumar 2021-09-08 11:11:54 Re: Gather performance analysis