Re: Tab completion support for ALTER SUBSCRIPTION REFRESH PUBLICATION

On Wed, Apr 12, 2017 at 11:48 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> On Wed, Apr 12, 2017 at 5:12 PM, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>> Hi,
>>
>> I've attached a patch for $subject. Please check it.
>
> + COMPLETE_WITH_LIST8("WITH", "CONNECTION", "SET PUBLICATION", "ENABLE",
> + "DISABLE", "OWNER TO", "RENAME TO", "REFRESH PUBLICATION WITH");
>
> "WITH" should be "WITH ("?
> Also "REFRESH PUBLICATION WITH" should be "REFRESH PUBLICATION WITH ("?

Agreed. I found other bugs of tab completion of PUB/SUB DDLs. Attached
latest patch incorporated these fixes.

>
> BTW, I found that ALTER SUBSCRIPTION ... RENAME TO exists in tab-complete.c,
> but not in the documentation. ALTER PUBLICATION has the same issue, too.
> So I think that we need to apply the attached patch which improves the
> documentation
> for ALTER PUBLICATION and SUBSCRIPTION.

+1

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center