Re: pgsql: Restrict the use of temporary namespace in two-phase transaction

From: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Restrict the use of temporary namespace in two-phase transaction
Date: 2019-01-22 04:47:05
Message-ID: CAD21AoCwHoZK8VP2q8W2htO_w6SH1m1MtEijGN-PFq8KX5dgUg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Sat, Jan 19, 2019 at 5:05 AM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>
> On Thu, Jan 17, 2019 at 8:08 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > > Anyway, it seems to me that this is pointing out to another issue:
> > > current_schema() can trigger a namespace creation, hence shouldn't we
> > > mark it as PARALLEL UNSAFE and make sure that we never run into this
> > > problem?
> >
> > That seems a bit annoying, but maybe we have little choice?
>
> The only other option I see is to make current_schema() not trigger a
> namespace creation.
>

Or can we make the test script set force_parallel_mode = off? Since
the failure case is a very rare in real world I think that it might be
better to change the test scripts rather than changing properly of
current_schema().

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2019-01-22 05:17:27 Re: pgsql: Restrict the use of temporary namespace in two-phase transaction
Previous Message Tom Lane 2019-01-22 04:19:24 pgsql: Avoid thread-safety problem in ecpglib.

Browse pgsql-hackers by date

  From Date Subject
Next Message Gavin Flower 2019-01-22 05:13:45 Re: Early WIP/PoC for inlining CTEs
Previous Message Amit Langote 2019-01-22 04:43:32 Typo: llvm*.cpp files identified as llvm*.c