Re: Eagerly scan all-visible pages to amortize aggressive vacuum

From: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
To: Melanie Plageman <melanieplageman(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Robert Treat <rob(at)xzilla(dot)net>, Marcos Pegoraro <marcos(at)f10(dot)com(dot)br>, Alena Rybakina <a(dot)rybakina(at)postgrespro(dot)ru>, Andres Freund <andres(at)anarazel(dot)de>, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Peter Geoghegan <pg(at)bowt(dot)ie>
Subject: Re: Eagerly scan all-visible pages to amortize aggressive vacuum
Date: 2025-01-29 17:58:53
Message-ID: CAD21AoCe=+Ho=zQTaVW=D=J-eqecy225gEt=VB5h0LDS_U83Ow@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jan 29, 2025 at 6:08 AM Melanie Plageman
<melanieplageman(at)gmail(dot)com> wrote:
>
> On Tue, Jan 28, 2025 at 4:38 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> >
> >
> > Thank you for updating the patch! These updates look good to me.
>
> Thanks for taking another look!
>
> > BTW I realized that we need to update tab-complete.c too to support
> > the tab-completion for vacuum_max_eager_freeze_failure_rate.
>
> I'm pretty sure tab-complete.c is auto-generated now. Tab completion
> for vacuum_max_eager_freeze_failure_rate worked for me without doing
> anything extra.

I missed to mention; it's about the tab completion for
vacuum_max_easter_freeze_failure storage parameter. We still need to
update the tab-complete.in.c file (I mentioned the wrong file
previously) for that.

Regards,

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2025-01-29 18:32:05 Re: Fwd: Why we need to check for local buffers in BufferIsExclusiveLocked and BufferIsDirty?
Previous Message Rafael Thofehrn Castro 2025-01-29 17:41:15 Re: Proposal: Progressive explain