From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
---|---|
To: | Neil Chen <carpenter(dot)nail(dot)cz(at)gmail(dot)com> |
Cc: | "Boris P(dot) Korzun" <drtr0jan(at)yandex(dot)ru>, "pgsql-bugs(at)lists(dot)postgresql(dot)org" <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Inconsistent behavior of pg_dump/pg_restore on DEFAULT PRIVILEGES |
Date: | 2021-10-14 00:59:23 |
Message-ID: | CAD21AoCc_wye_yfSkgLYSyUz6UKKGmXRaMFpsw=eOVHNaSShwQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs pgsql-hackers |
On Fri, Oct 1, 2021 at 11:13 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> On Wed, Sep 22, 2021 at 10:31 AM Neil Chen <carpenter(dot)nail(dot)cz(at)gmail(dot)com> wrote:
> >
> > Hi Boris,
> >
> > Actually, because I am a PG beginner, I am not familiar with the rules of the community. What extra work do I need to do to submit to the upstream? This bug discussion doesn't seem to see the concern of others.
>
> As far as I checked this bug still exists in all supported branches
> (from 10 to 14, and HEAD). I'd recommend adding this patch to the next
> commit fest so as not to forget, if not yet.
>
> I agree with your analysis on this bug. For non-default
> (defaclnamespace != 0) entries, their acl should be compared to NULL.
>
> The fix also looks good to me. But I think it'd be better to add tests for this.
>
Since the patch conflicts with the current HEAD, I've rebased and
slightly updated the patch, adding the regression tests.
Regards,
--
Masahiko Sawada
EDB: https://www.enterprisedb.com/
Attachment | Content-Type | Size |
---|---|---|
fix-bug-on-dump-default-ACL_v2.patch | application/octet-stream | 2.0 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Geoghegan | 2021-10-14 01:26:20 | Re: IRe: BUG #16792: silent corruption of GIN index resulting in SELECTs returning non-matching rows |
Previous Message | Masahiko Sawada | 2021-10-14 00:36:55 | Re: Inconsistent behavior of pg_dump/pg_restore on DEFAULT PRIVILEGES |
From | Date | Subject | |
---|---|---|---|
Next Message | Kyotaro Horiguchi | 2021-10-14 01:09:56 | Re: Allow escape in application_name |
Previous Message | Masahiko Sawada | 2021-10-14 00:36:55 | Re: Inconsistent behavior of pg_dump/pg_restore on DEFAULT PRIVILEGES |