| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Reviewing freeze map code |
| Date: | 2016-05-09 03:44:39 |
| Message-ID: | CAD21AoCQGTKDxQ6YfrJ0+=ev6A3i3pt2ULdWxCtwPLKR2E77jg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, May 3, 2016 at 6:48 AM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> fd31cd2 Don't vacuum all-frozen pages.
- appendStringInfo(&buf, _("pages: %u removed,
%u remain, %u skipped due to pins\n"),
+ appendStringInfo(&buf, _("pages: %u removed,
%u remain, %u skipped due to pins, %u skipped frozen\n"),
vacrelstats->pages_removed,
vacrelstats->rel_pages,
-
vacrelstats->pinskipped_pages);
+
vacrelstats->pinskipped_pages,
+
vacrelstats->frozenskipped_pages);
The verbose information about skipping frozen page is emitted by only
autovacuum.
But I think that this information is also helpful for manual vacuum.
Please find attached patch which fixes that.
Regards,
--
Masahiko Sawada
| Attachment | Content-Type | Size |
|---|---|---|
| lazy_scan_heap_verbose_output.patch | text/x-patch | 639 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2016-05-09 05:47:57 | Re: pg9.6 segfault using simple query (related to use fk for join estimates) |
| Previous Message | Michael Paquier | 2016-05-09 02:58:45 | Re: [COMMITTERS] pgsql: Add TAP tests for pg_dump |