| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: subscription/033_run_as_table_owner is not listed in the meson.build |
| Date: | 2023-06-15 22:15:36 |
| Message-ID: | CAD21AoCESpwYHR9OiGdznRAmpOtJwYDW_Tz=Hwm=pOT4dWF+TQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jun 15, 2023 at 5:32 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> On Thu, Jun 15, 2023 at 5:04 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> >
> > On Thu, Jun 15, 2023 at 07:16:06AM +0000, Hayato Kuroda (Fujitsu) wrote:
> > > I have noticed that the testcase subscription/033_run_as_table_owner in the
> > > subscription is not executed when meson build system is chosen. The case is not
> > > listed in the meson.build.
> > >
> > > Do we have any reasons or backgrounds about it?
> > > PSA the patch to add the case. It works well on my env.
> >
> > Seems like a thinko of 4826759 to me, that's easy to miss. Will fix
> > in a bit..
>
> Good catch.
>
> Checking similar oversights,
> src/bin/pg_basebackup/t/011_in_place_tablespace.pl seems not to be
> listed in meson.build too.
Here is the patch for that.
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Add-missing-pg_basebackup-TAP-test-for-meson.patch | application/octet-stream | 938 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2023-06-15 22:34:54 | Re: Memory leak in incremental sort re-scan |
| Previous Message | Joel Jacobson | 2023-06-15 21:05:38 | Re: Do we want a hashset type? |