| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Arseny Sher <a(dot)sher(at)postgrespro(dot)ru> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Flaky vacuum truncate test in reloptions.sql |
| Date: | 2021-04-01 02:33:54 |
| Message-ID: | CAD21AoBrNFeBRT-AkVyMybr=bmUbiAcpZPsD61Q_tgvAUqUuHQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 31, 2021 at 10:39 PM Arseny Sher <a(dot)sher(at)postgrespro(dot)ru> wrote:
>
>
> On 3/31/21 4:17 PM, Masahiko Sawada wrote:
>
> > Is it better to add FREEZE to the first "VACUUM reloptions_test;" as
> well?
>
> I don't think this matters much, as it tests the contrary and the
> probability of
> successful test passing (in case of theoretical bug making vacuum to
> truncate
> non-empty relation) becomes stunningly small. But adding it wouldn't hurt
> either.
I was concerned a bit that without FREEZE in the first VACUUM we could
not test it properly because the table could not be truncated because
either vacuum_truncate is off or the page is skipped.
Regards,
--
Masahiko Sawada
EDB: https://www.enterprisedb.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2021-04-01 02:56:43 | Re: Crash in BRIN minmax-multi indexes |
| Previous Message | Mark Dilger | 2021-04-01 02:28:56 | Re: multi-install PostgresNode fails with older postgres versions |