Re: Server Crashes if try to provide slot_name='none' at the time of creating subscription.

From: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
To: tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Server Crashes if try to provide slot_name='none' at the time of creating subscription.
Date: 2017-05-15 10:30:13
Message-ID: CAD21AoBpYyg_SrgM_4ic9F_+yOJyBuHej44O5qjXhEnPos1AWA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, May 15, 2017 at 6:41 PM, tushar <tushar(dot)ahuja(at)enterprisedb(dot)com> wrote:
> Hi,
>
> Server Crashes if we try to provide slot_name='none' at the time of creating
> subscription -
>
> postgres=# create subscription sub2 connection 'dbname=postgres port=5000
> user=centos password=f' publication abc with (slot_name='none');
> NOTICE: synchronized table states
> server closed the connection unexpectedly
> This probably means the server terminated abnormally
> before or while processing the request.
> The connection to the server was lost. Attempting reset: Failed.
> !>
>

Thank you for reporting.
I think create_slot and enabled should be set to false forcibly when
slot_name = 'none'. Attached patch fixes it, more test and regression
test case are needed though.

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

Attachment Content-Type Size
fix_bug_of_parse_option.patch application/octet-stream 838 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message amul sul 2017-05-15 10:57:13 Re: [POC] hash partitioning
Previous Message Dilip Kumar 2017-05-15 10:02:31 Re: Bug in ExecModifyTable function and trigger issues for foreign tables