From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Upper limit arguments of pg_logical_slot_xxx_changes functions accept invalid values |
Date: | 2018-07-27 05:18:16 |
Message-ID: | CAD21AoBpR_NMTj822c0CywyF_NrTJ_6Y+aAc1iM75p45mR55Kg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Thank you for comment!
On Fri, Jul 27, 2018 at 7:27 AM, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Thu, Jul 12, 2018 at 09:58:16AM +0900, Masahiko Sawada wrote:
>> If upto_lsn is non-NULL, decoding will include only those
>> transactions which commit prior to the specified LSN. If upto_nchanges
>> is non-NULL, decoding will stop when the number of rows produced by
>> decoding exceeds the specified value.
>
> It is also possible to interpret a negative value as an equivalent to
> infinite, no? That's how I read the documentation quote you are adding
> here.
Given the meaning of upto_nchanges I would expect that the "non-NULL"
is a positive value but it's possible to interpret as you mentioned.
Maybe this patch should fix only the code setting InvalidXLogRecPtr to
upto_nchanges.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
From | Date | Subject | |
---|---|---|---|
Next Message | David Rowley | 2018-07-27 05:46:44 | Re: Speeding up INSERTs and UPDATEs to partitioned tables |
Previous Message | Michael Paquier | 2018-07-27 04:44:58 | Re: pgbench - very minor bug fix on hash() missing argument |