Re: vacuumdb and new VACUUM options

From: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Euler Taveira <euler(at)timbira(dot)com(dot)br>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: vacuumdb and new VACUUM options
Date: 2019-05-09 11:14:51
Message-ID: CAD21AoBmA9H3ZRuQFF+9io9PKhP+ePS=D+ThZ6ohRMdBm2x8Pw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, May 9, 2019 at 10:01 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Wed, May 08, 2019 at 06:21:09PM -0300, Euler Taveira wrote:
> > Em qua, 8 de mai de 2019 às 14:19, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> escreveu:
> >> The question is; we should support vacuumdb option for (1), i.e.,,
> >> something like --index-cleanup option is added?
> >> Or for (2), i.e., something like --disable-index-cleanup option is added
> >> as your patch does? Or for both?
> >
> > --index-cleanup=BOOL
>
> I agree with Euler's suggestion to have a 1-1 mapping between the
> option of vacuumdb and the VACUUM parameter

+1. Attached the draft version patches for both options.

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

Attachment Content-Type Size
v2-0001-Add-index-cleanup-option-to-vacuumdb.patch application/octet-stream 6.9 KB
v2-0002-Add-truncate-option-to-vacuumdb.patch application/octet-stream 5.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro HORIGUCHI 2019-05-09 11:38:16 Re: vacuumdb and new VACUUM options
Previous Message Etsuro Fujita 2019-05-09 11:09:33 Re: Missing FDW documentation about GetForeignUpperPaths