| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Fix tab-completion of ALTER SUBSCRIPTION SET PUBLICATION |
| Date: | 2017-06-07 03:52:28 |
| Message-ID: | CAD21AoBfii3ok8htiEQVzZKDfhCSM6pbWahDR3sdawBG8hekMQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jun 7, 2017 at 12:41 PM, Peter Eisentraut
<peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
> On 6/6/17 04:17, Masahiko Sawada wrote:
>> With this patch, ALTER SUBSCRIPTION <sub> SET PUBLICATION <pub> [TAB]
>> completes with "REFRESH" and "SKIP REFRESH".
>> Specifying either REFRESH or SKIP REFRESH is mandatory after ALTER
>> SUBSCRIPTION SET PUBLICATION, so i think it's good to add this.
>
> That syntax does not exist anymore.
>
> You could add support for the new WITH () syntax.
>
Sorry, I missed it.
Attached updated version patch adds WITH() syntax.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
| Attachment | Content-Type | Size |
|---|---|---|
| fix_ALTER_SUB_tab_completion_v2.patch | application/octet-stream | 900 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-06-07 04:03:15 | Re: Parallel Aggregation support for aggregate functions that use transitions not implemented for array_agg |
| Previous Message | Regina Obe | 2017-06-07 03:52:08 | Re: Parallel Aggregation support for aggregate functions that use transitions not implemented for array_agg |