Re: Design of pg_stat_subscription_workers vs pgstats

On Mon, Feb 28, 2022 at 11:52 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Mon, Feb 28, 2022 at 8:17 AM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> >
> > On Mon, Feb 28, 2022 at 11:33 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> > >
> > > >
> > > > (2) doc/src/sgml/monitoring.sgml
> > > >
> > > > + Resets statistics for a single subscription shown in the
> > > > + <structname>pg_stat_subscription_stats</structname> view to zero. If
> > > > + the argument is <literal>NULL</literal>, reset statistics for all
> > > > + subscriptions.
> > > > </para>
> > > >
> > > > I felt we could improve the first sentence.
> > > >
> > > > From:
> > > > Resets statistics for a single subscription shown in the..
> > > >
> > > > To(idea1):
> > > > Resets statistics for a single subscription defined by the argument to zero.
> > > >
> > >
> > > Okay, I can use this one.
> >
> > Are you going to remove the part "shown in the
> > pg_stat_subsctiption_stats view"? I think it's better to keep it in
> > order to make it clear which statistics the function resets as we have
> > pg_stat_subscription and pg_stat_subscription_stats.
> >
>
> How about the following:
> "Resets statistics for a single subscription defined by the argument
> shown in the <structname>pg_stat_subscription_stats</structname> view
> to zero. If the argument is <literal>NULL</literal>, reset statistics
> for all subscriptions."

Sounds good but I'm not sure it's correct in terms of English grammar.
Shouldn't it be something like "subscription that is defined by the
argument and shown in the pg_stat_subscription_stats"?

Regards,

--
Masahiko Sawada
EDB: https://www.enterprisedb.com/