Re: pgsql: Move parallel vacuum code to vacuumparallel.c.

On Thu, Dec 23, 2021 at 3:49 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Thu, Dec 23, 2021 at 11:50 AM Amit Kapila <akapila(at)postgresql(dot)org> wrote:
> >
> > Move parallel vacuum code to vacuumparallel.c.
> >
>
> There appears to be one failure:
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=prairiedog&dt=2021-12-23%2006%3A26%3A03.
>

I could reproduce this error by compiling with '-std=gnu99' on my
machine (macOS):

vacuumparallel.c:198:3: warning: redefinition of typedef
'ParallelVacuumState' is a C11 feature [-Wtypedef-redefinition]
} ParallelVacuumState;
^
../../../src/include/commands/vacuum.h:68:36: note: previous definition is here
typedef struct ParallelVacuumState ParallelVacuumState;
^
1 warning generated.

It seems a C11 feature. The attached patch fixes this issue.

Regards,

--
Masahiko Sawada
EDB: https://www.enterprisedb.com/