From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
---|---|
To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
Cc: | Simon Riggs <simon(at)2ndquadrant(dot)com>, pgsql-committers <pgsql-committers(at)postgresql(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pgsql: Allow vacuums to report oldestxmin |
Date: | 2017-03-25 17:26:20 |
Message-ID: | CAD21AoAuvJGUE3d69od8wbg4ZRTj=fiBTf=fXNVpsqF-LEFcsw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On Sun, Mar 26, 2017 at 1:37 AM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> On Mon, Mar 6, 2017 at 9:37 PM, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>> On Fri, Mar 3, 2017 at 10:50 PM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
>>> Allow vacuums to report oldestxmin
>>>
>>> Allow VACUUM and Autovacuum to report the oldestxmin value they
>>> used while cleaning tables, helping to make better sense out of
>>> the other statistics we report in various cases.
>>>
>>> Branch
>>> ------
>>> master
>>>
>>> Details
>>> -------
>>> http://git.postgresql.org/pg/commitdiff/9eb344faf54a849898d9be012ddfa8204cfeb57c
>>>
>>> Modified Files
>>> --------------
>>> src/backend/commands/vacuumlazy.c | 9 +++++----
>>> 1 file changed, 5 insertions(+), 4 deletions(-)
>>>
>>>
>>
>> Should we change the example in vacuum.sgml file as well? Attached patch.
>
> "tuples" in the above should be "row versions"?
> We should review not only this line but also all the lines in the example
> of VERBOSE output, I think.
Right. These verbose log messages are out of date. I ran
VACUUM(VERBOSE, ANALYZE) with same scenario as current example as
possible. Attached patch updates verbose log messages.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
Attachment | Content-Type | Size |
---|---|---|
fix_vacuum_example_in_doc_v2.patch | application/octet-stream | 3.6 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2017-03-25 21:32:35 | pgsql: Re-adhere to policy of no more than 20 tests per parallel group. |
Previous Message | Fujii Masao | 2017-03-25 16:37:21 | Re: pgsql: Allow vacuums to report oldestxmin |
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Geoghegan | 2017-03-25 17:33:37 | Re: Patch: Write Amplification Reduction Method (WARM) |
Previous Message | Peter Eisentraut | 2017-03-25 17:02:08 | Re: increasing the default WAL segment size |