Re: doc: pg_trgm missing description for GUC "pg_trgm.strict_word_similarity_threshold"

From: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
To: Ian Barwick <ian(dot)barwick(at)2ndquadrant(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>
Subject: Re: doc: pg_trgm missing description for GUC "pg_trgm.strict_word_similarity_threshold"
Date: 2019-06-07 06:44:14
Message-ID: CAD21AoAgPKODUsu9gqUFiNqEOAqedStxJ-a0sapsJXWWAVp=xg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jun 6, 2019 at 10:19 PM Ian Barwick <ian(dot)barwick(at)2ndquadrant(dot)com> wrote:
>
> Hi
>
> Commit be8a7a68662 added custom GUC "pg_trgm.strict_word_similarity_threshold",
> but omitted to document this in the section "GUC Parameters";

Indeed.

BTW while looking GUC variables defined in trgm_op.c the operators in
each short description seems not correct; there is an extra percent
sign. Should we also fix them?

postgres(1:43133)=# select name, short_desc from pg_settings where
name like 'pg_trgm%';
name | short_desc
------------------------------------------+-----------------------------------------------
pg_trgm.similarity_threshold | Sets the threshold used by
the %% operator.
pg_trgm.strict_word_similarity_threshold | Sets the threshold used by
the <<%% operator.
pg_trgm.word_similarity_threshold | Sets the threshold used by
the <%% operator.

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2019-06-07 06:59:49 Re: Should we warn against using too many partitions?
Previous Message Masahiko Sawada 2019-06-07 06:30:35 Re: Small review comment on pg_checksums