| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Richard Guo <guofenglinux(at)gmail(dot)com>, Japin Li <japinli(at)hotmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Replace (GUC_UNIT_MEMORY | GUC_UNIT_TIME) with GUC_UNIT in guc.c |
| Date: | 2023-06-15 02:02:07 |
| Message-ID: | CAD21AoAd+SC=G_CC_=QdvVdeqjHGs1SgeQPU5vB4CYhrgd5QYQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jun 14, 2023 at 4:47 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Wed, Jun 14, 2023 at 03:38:10PM +0800, Richard Guo wrote:
> > +1. BTW, it seems that GUC_UNIT_TIME is not used anywhere except in
> > GUC_UNIT. I was wondering if we can retire it, but maybe we'd better
> > not. It still indicates that we need to use time units table.
>
> Some out-of-core code declaring custom GUCs could rely on that, so
> it is better not to remove it.
+1 not to remove it.
I've attached the patch to fix (GUC_UNIT_MEMORY | GUC_UNIT_TIME)
thing, and am going to push it later today to only master branch.
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Replace-GUC_UNIT_MEMORY-GUC_UNIT_TIME-with-GUC_UN.patch | application/octet-stream | 1.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2023-06-15 02:07:05 | Re: Shouldn't cost_append() also scale the partial path's cost? |
| Previous Message | Vladimir Churyukin | 2023-06-15 01:37:00 | Re: Bypassing shared_buffers |