| From: | Sawada Masahiko <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: The number of character limitation of custom script on pgbench |
| Date: | 2013-11-13 14:15:29 |
| Message-ID: | CAD21AoAY7OMsYgMX7YcN4=ap1mFn=kh+ma0+ZXebM2ZyC67bUA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Nov 13, 2013 at 10:27 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
>> On 11/13/13, 6:18 AM, Sawada Masahiko wrote:
>>> The function of custom script of pgbench allows only BUFSIZ
>>> (i.g.,1024byte) or less as length of a SQL.
>>> So I'm thinking following solution.
>>> (1) to increase buffer size
>>> (2) to change to variable buffer size
>>> (3) to return ERROR with information
>
>> I'd go for #2. But at least an error.
>
> #2 definitely. I've run into this limitation myself recently, and
> so have other people. It's time to fix it.
>
Yes, I also think #2 is good.
I will implement the patch.
Regards,
-------
Sawada Masahiko
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Leonardo Francalanci | 2013-11-13 14:29:53 | Re: Fast insertion indexes: why no developments |
| Previous Message | Peter Eisentraut | 2013-11-13 14:07:17 | Re: UTF8 national character data type support WIP patch and list of open issues. |