From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
---|---|
To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
Cc: | Greg Nancarrow <gregn4422(at)gmail(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, "osumi(dot)takamichi(at)fujitsu(dot)com" <osumi(dot)takamichi(at)fujitsu(dot)com>, Alexey Lesovsky <lesovsky(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Skipping logical replication transactions on subscriber side |
Date: | 2021-11-09 12:55:34 |
Message-ID: | CAD21AoAPsz3ceHmBn0hT4x6sWz_jj_MWAeXc+vGQgAjN=_Ni=A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Nov 9, 2021 at 7:04 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Tue, Nov 9, 2021 at 12:13 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> >
> > On Tue, Nov 9, 2021 at 3:08 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> > >
> > >
> > > 4. It seems now stats_reset entry is not present in
> > > pg_stat_subscription_workers? How will users find that information if
> > > required?
> >
> > Users can find it in pg_stat_databases. The same is true for table and
> > function statistics -- they don't have stats_reset column but reset
> > stats_reset of its entry on pg_stat_database.
> >
>
> Okay, but isn't it better to deal with the reset of subscription
> workers via pgstat_recv_resetsinglecounter by introducing subobjectid?
> I think that will make code consistent for all database-related stats.
>
Agreed. It's better to use the same function internally even if the
SQL-callable interfaces are different.
Regards,
--
Masahiko Sawada
EDB: https://www.enterprisedb.com/
From | Date | Subject | |
---|---|---|---|
Next Message | Daniel Gustafsson | 2021-11-09 13:11:51 | Re: pg_rewind copies |
Previous Message | Masahiko Sawada | 2021-11-09 12:53:40 | Re: parallel vacuum comments |