| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_ctl promote wait |
| Date: | 2016-09-22 15:16:05 |
| Message-ID: | CAD21AoA6DYzz98jT86Wbwr+12VkpH5FuQL2U_a2DBBBZAJ4YxQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Sep 22, 2016 at 1:25 AM, Peter Eisentraut
<peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
> On 8/11/16 9:28 AM, Michael Paquier wrote:
>> I have looked at them and the changes are looking fine for me. So I
>> have switched the patch as ready for committer, aka you.
>>
>> Just a nit:
>> + if (wait_seconds > 0)
>> + {
>> + sleep(1);
>> + wait_seconds--;
>> + continue;
>> + }
>> This may be better this pg_usleep() instead of sleep().
>
> Committed with that adjustment.
>
Commit e7010ce seems to forget to change help message of pg_ctl.
Attached patch.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
| Attachment | Content-Type | Size |
|---|---|---|
| fix_pg_ctl_help.patch | application/octet-stream | 650 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2016-09-22 15:30:25 | Re: ICU integration |
| Previous Message | Andrew Dunstan | 2016-09-22 15:15:45 | Re: [PATCH] pgpassfile connection option |