Re: pg_dump refactor patch to remove global variables

Fixed and rebased patch attached.

On Tue, Aug 26, 2014 at 11:40 AM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> On 8/15/14 7:30 PM, Joachim Wieland wrote:
>> Attached is a patch that doesn't add any new functionality or
>> features, all it does is get rid of the global variables that
>> pg_dump.c is full of.
>
> I'm getting a compiler error:
>
> In file included from pg_dump.c:60:
> In file included from ./pg_backup_archiver.h:32:
> ./pg_backup.h:212:3: error: redefinition of typedef 'DumpOptions' is a
> C11 feature [-Werror,-Wtypedef-redefinition]
> } DumpOptions;
> ^
> ./pg_dump.h:507:29: note: previous definition is here
> typedef struct _dumpOptions DumpOptions;
> ^
> 1 error generated.
>