From: | Atul Sharma <atul(dot)sharma(at)enterprisedb(dot)com> |
---|---|
To: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com> |
Cc: | Dave Page <dpage(at)pgadmin(dot)org>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: pgAdmin 4 commit: Bundle fonts with pgAdmin so we have a standard set f |
Date: | 2017-09-15 07:59:21 |
Message-ID: | CACsXrw7cTKvnHPvBS1ULyDHj70OcAYyjsTrDSkWYrdrY8rt6jw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi,
PFA patch which replaces the "Roboto" font family with "Open Sans" for
alertify dialogs. Regarding Query tool context menu, It seems different
issue than the applied fonts.
Regards,
Atul
On Thu, Sep 14, 2017 at 7:49 PM, Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> Attaching more screenshots.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> [image: https://community.postgresrocks.net/]
> <https://community.postgresrocks.net/>
>
> On Thu, Sep 14, 2017 at 7:08 PM, Murtuza Zabuawala <murtuza.zabuawala@
> enterprisedb.com> wrote:
>
>> Hi Atul,
>>
>> Please also check fonts in various the alertify dialogs.
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> [image: https://community.postgresrocks.net/]
>> <https://community.postgresrocks.net/>
>>
>> On Thu, Sep 14, 2017 at 7:03 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>>> Nope - it shouldn't look like that. Atul, Can you take a look at it
>>> please?
>>>
>>> On Thu, Sep 14, 2017 at 2:26 PM, Murtuza Zabuawala <
>>> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi Dave,
>>>>
>>>> After latest pull fonts from context menu looks different, PFA
>>>> screenshot.
>>>> I tried on macOS: 10.10 (Web mode) on Google Chrome: Version
>>>> 60.0.3112.113 (Official Build) (64-bit)
>>>>
>>>> Is this expected behaviour?
>>>>
>>>>
>>>> --
>>>> Regards,
>>>> Murtuza Zabuawala
>>>> EnterpriseDB: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>> [image: https://community.postgresrocks.net/]
>>>> <https://community.postgresrocks.net/>
>>>>
>>>> On Wed, Sep 13, 2017 at 8:31 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>>
>>>>> Bundle fonts with pgAdmin so we have a standard set for all platforms.
>>>>>
>>>>> Research by Shirley at Pivotal.
>>>>>
>>>>> Branch
>>>>> ------
>>>>> master
>>>>>
>>>>> Details
>>>>> -------
>>>>> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdif
>>>>> f;h=788f7f3a69500c37008dbba459d3ea00b0b1bff8
>>>>> Author: Atul Sharma <atul(dot)sharma(at)enterprisedb(dot)com>
>>>>>
>>>>> Modified Files
>>>>> --------------
>>>>> libraries.txt | 4 ++-
>>>>> web/pgadmin/browser/static/css/browser.css | 33
>>>>> ++++++++++++++-------
>>>>> .../misc/bgprocess/static/css/bgprocess.css | 2 +-
>>>>> .../misc/file_manager/static/css/file_manager.css | 2 +-
>>>>> web/pgadmin/static/css/aci_tree.overrides.css | 4 +--
>>>>> web/pgadmin/static/css/bootstrap.overrides.css | 5 ++--
>>>>> web/pgadmin/static/css/codemirror.overrides.css | 4 +--
>>>>> web/pgadmin/static/css/pgadmin.css | 17 ++++++++++-
>>>>> web/pgadmin/static/css/pgadmin.style.css | 10 +++----
>>>>> web/pgadmin/static/css/webcabin.overrides.css | 6 ++--
>>>>> web/pgadmin/static/fonts/OpenSans-Bold.ttf | Bin 0 -> 224452
>>>>> bytes
>>>>> web/pgadmin/static/fonts/OpenSans-Italic.ttf | Bin 0 -> 212760
>>>>> bytes
>>>>> web/pgadmin/static/fonts/OpenSans-Regular.ttf | Bin 0 -> 217276
>>>>> bytes
>>>>> web/pgadmin/static/fonts/OpenSans-SemiBold.ttf | Bin 0 -> 221164
>>>>> bytes
>>>>> web/pgadmin/static/fonts/SourceCodePro-Bold.ttf | Bin 0 -> 120504
>>>>> bytes
>>>>> web/pgadmin/static/fonts/SourceCodePro-Regular.ttf | Bin 0 -> 120548
>>>>> bytes
>>>>> web/pgadmin/static/scss/_alert.scss | 2 +-
>>>>> web/pgadmin/static/scss/_alertify.overrides.scss | 2 +-
>>>>> web/pgadmin/static/scss/_typography.scss | 2 +-
>>>>> web/pgadmin/static/scss/sqleditor/_history.scss | 8 ++---
>>>>> web/pgadmin/tools/debugger/static/css/debugger.css | 6 ++--
>>>>> .../tools/sqleditor/static/css/sqleditor.css | 8 ++---
>>>>> 22 files changed, 73 insertions(+), 42 deletions(-)
>>>>>
>>>>>
>>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>
Attachment | Content-Type | Size |
---|---|---|
fonts_v1.patch | application/octet-stream | 336 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Harshal Dhumal | 2017-09-15 12:46:59 | Re: Array representation and save array data from datagrid [RM2671][pgAdmin4] |
Previous Message | Murtuza Zabuawala | 2017-09-15 07:52:40 | [pgAdmin4][Patch]: Fix context menu fontawesome icons |