Re: [pgAdmin4][Patch][RM_2567] : Default privileges don't show on Properties tab for database.

From: Atul Sharma <atul(dot)sharma(at)enterprisedb(dot)com>
To: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
Cc: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch][RM_2567] : Default privileges don't show on Properties tab for database.
Date: 2017-08-08 09:55:17
Message-ID: CACsXrw71rZtnyH6w6_h43DddZse3coNn=d_HQft+gdfGNshz5A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

makes sense. Thanks for the solution.

Please find attached revised patch.

Thanks,
Atul

On Tue, Aug 8, 2017 at 2:12 PM, Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:

> Hi Atul,
>
> Better solution to solve this issue is to use self.conn instead of
> creating new conn using did, we already checking for "datallowconn" flag
> in check_precondition decorator.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> [image: https://community.postgresrocks.net/]
> <https://community.postgresrocks.net/>
>
> On Tue, Aug 8, 2017 at 12:42 PM, Atul Sharma <atul(dot)sharma(at)enterprisedb(dot)com
> > wrote:
>
>> ok, Lemme check and I will get back to you.
>>
>> Thanks,
>> Atul
>>
>> On Tue, Aug 8, 2017 at 12:40 PM, Murtuza Zabuawala <
>> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Atul,
>>>
>>> The given patch breaks RM#1801
>>> <https://redmine.postgresql.org/issues/1801>.
>>> After applying the patch, Now I'm not able to see the properties of a
>>> database of which "datallowconn" is set to False.
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>> [image: https://community.postgresrocks.net/]
>>> <https://community.postgresrocks.net/>
>>>
>>> On Tue, Aug 8, 2017 at 12:08 PM, Ashesh Vashi <
>>> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>>>
>>>> Murtuza,
>>>>
>>>> Please review this one.
>>>>
>>>> --
>>>>
>>>> Thanks & Regards,
>>>>
>>>> Ashesh Vashi
>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>>>> <http://www.enterprisedb.com>
>>>>
>>>>
>>>> *http://www.linkedin.com/in/asheshvashi*
>>>> <http://www.linkedin.com/in/asheshvashi>
>>>>
>>>> On Tue, Aug 1, 2017 at 3:23 PM, Atul Sharma <
>>>> atul(dot)sharma(at)enterprisedb(dot)com> wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> PFA patch that fixes Default privileges don't show on Properties tab
>>>>> for database
>>>>>
>>>>> Thanks,
>>>>> Atul
>>>>>
>>>>
>>>>
>>>
>>
>

Attachment Content-Type Size
RM_2567_v2.patch application/octet-stream 2.2 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Murtuza Zabuawala 2017-08-08 10:16:08 Re: [pgAdmin4][PATCH] Refactor and change of implementation of keyboard_shortcuts function dependencies
Previous Message Wenlin Zhang 2017-08-08 09:45:33 Re: [pgAdmin4][patch] update the alert style in the sub-navigation